-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version #731
Bump version #731
Conversation
Change-Id: Ida82c6eafa715069d62dc92eb19accf64ed6d51c
I see some references to the ability to restore data with Seedvault after setup. I'm not sure if this has been merged or not and so I haven't included it. Let me know if I should. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thanks a lot!
I see some references to the ability to restore data with Seedvault after setup. I'm not sure if this has been merged or not and so I haven't included it. Let me know if I should.
This should go in soon. Once #723 is merged. Could already be added to the changelog and we merge this PR afterwards!
1fe42b9
to
1d95ccd
Compare
1d95ccd
to
006dfad
Compare
My only adversion to this is that it might look weird in git history. The true start of 14-4.1 would be when the merge commit shows up, but the commit for the bump and changelog itself may come before that, which may cause confusion. Also do you guys not do tags? I see only for like 2021 versions, it makes me a bit confused on whether Seedvault is meant to be merged constantly or based on versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Version is updated as expected when building with this, in app info and About page.
So I guess the remaining question is when to merge? And then if there are more changes merged before then, update the changelog again?
No description provided.